build(deps): bump github.com/bombsimon/wsl/v4 from 3.4.0 to 4.2.0

[alexandear]

Bumps github.com/bombsimon/wsl/v4 from 3.4.0 to 4.2.0.

bombsimon/wsl@v3.4.0...v4.2.0

This update is done by hand because dependabot is not able to update a major version of a dependency.

[ldez]

@bombsimon It seems there is a regression on line directives, can you take a look?

[bombsimon]

Super nice that you added the tests @ldez! ⭐ This would've caused the same issue that I just fixed in #3967

However, that's not the reason the test fails. The reason is this code.

The reason I added this is because without this running the analyzer will also operate on non source files from the cache. If I remove these lines, this is what I currently get running in its own repo:

› go run ./cmd/wsl ./...
/Users/simon/Library/Caches/go-build/2b/2b593556207605cff3837705ff4e2fcabdca47a62d42266c0a3a71c407e20003-d:47:14: block should not start with a whitespace
/Users/simon/Library/Caches/go-build/2b/2b593556207605cff3837705ff4e2fcabdca47a62d42266c0a3a71c407e20003-d:53:1: block should not end with a whitespace (or comment)
exit status 3

The same code was added in gochecknoglobals here. That was added by me as well and here's some background to that: leighmcculloch/gochecknoglobals#16 (comment). As seen in that and the comment after both gochecknoglobals and go-mnd processed go files from the cache.

I don't know why this isn't an issue with more linters, maybe because they have a smaller scope and not as strict or opinionated lints? I never got around to dig deeper to why this is happening.

Do you have any suggestions on how to get rid of the constraint of only checking .go suffixed files but also not processing the files from the cache?

[bombsimon]

I created golang/go#64436 but then I saw that generated code in general was discussed in golang/go#43481. Since I was using Position instead of PositionFor when getting the filename I changed that instead.

I don't know what's expected here actually but I think filtering out files manually like suggested in the linked issue is reasonable and in this case it will work just fine after moving to PositionFor.

I updated wsl and released v4.2.0 which fixes the line directive test.

[ldez]

LGTM