Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.golangci.reference.yml: depguard notice #4227

Closed
wants to merge 1 commit into from
Closed

.golangci.reference.yml: depguard notice #4227

wants to merge 1 commit into from

Conversation

oliverpool
Copy link

When using depguard, special care must be taken to adjust the "Deny" key, otherwise a panic happens:

ERRO [runner] Panic: depguard: package "..." (isInitialPkg: true, needAnalyzeSource: true): runtime error: index out of range [-1]

OpenPeeDeeP/depguard#74

Copy link

boring-cyborg bot commented Dec 1, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@oliverpool
Copy link
Author

@CLAassistant I refuse to sign a CLA which:

grant to GolangCI and to recipients of software distributed by GolangCI a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to use, copy, reproduce, prepare derivative works of, sublicense, distribute and publicly perform and display the Contributions on any licensing terms, including without limitation: (a) open source licenses like the MIT license; and (b) binary, proprietary, or commercial licenses.

I can happily provide a Developer Certificate of Origin (DCO), stating that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the Free Software license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate Free Software
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same Free Software license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the Free Software license(s) involved.

(The "Free Software license" being GPL-3.0)

Anyway I believe such a minor change is not covered by copyright (nothing original here).

@ldez
Copy link
Member

ldez commented Dec 1, 2023

To sign the CLA is required.

Anyway, the change of this PR talks about something not supported by our configuration: pkg and desc are required by our configuration, and the reason behind these requirements is not needed for users.

@ldez ldez closed this Dec 1, 2023
@ldez ldez added the declined label Dec 1, 2023
yannuil added a commit to yannuil/maistra-xns-informer that referenced this pull request Mar 18, 2024
For details, please check out this [PR](golangci/golangci-lint#4227).

Signed-off-by: Yann Liu <yannliu@redhat.com>
openshift-merge-bot bot pushed a commit to maistra/xns-informer that referenced this pull request Mar 18, 2024
* Update deps

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Update API groups

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Run make gen

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Use the same version gateway-api as in upstream 1.20

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Update openshift packages

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Use the same istio client-go as in the upstream 1.20

Signed-off-by: Yann Liu <yannliu@redhat.com>

* Update depguard configuration as a golangci limitation

For details, please check out this [PR](golangci/golangci-lint#4227).

Signed-off-by: Yann Liu <yannliu@redhat.com>

---------

Signed-off-by: Yann Liu <yannliu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants