Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: fix govet.nilness lint issues #4373

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

alexandear
Copy link
Member

This PR enables nilness analyzer for govet and fixes up appearing lint issues through golangci-lint repo:

❯ golangci-lint run
pkg/lint/lintersdb/manager.go:239:15: nilness: tautological condition: non-nil != nil (govet)
                if govetCfg != nil {
                            ^
pkg/lint/lintersdb/manager.go:243:18: nilness: tautological condition: non-nil != nil (govet)
                if gocriticCfg != nil {
                               ^
pkg/lint/lintersdb/manager.go:247:17: nilness: tautological condition: non-nil != nil (govet)
                if gofumptCfg != nil && gofumptCfg.LangVersion == "" {
                              ^

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Feb 10, 2024
@ldez ldez merged commit cc3e67b into golangci:master Feb 10, 2024
12 checks passed
@alexandear alexandear deleted the dev-fix-govet-nilness branch February 10, 2024 12:11
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants