Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add tests on linterdb package #4416

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 25, 2024

  • add tests on Validator
  • add tests on EnableSet

I don't add tests on the Manager because I will add them in the PR with the rewrite of the Manager (this is the step next after #4412).

@ldez ldez added enhancement New feature or improvement area: tests Continuous integration, tests and other checks labels Feb 25, 2024
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ldez ldez merged commit b172ad4 into golangci:master Feb 26, 2024
12 checks passed
@ldez ldez deleted the feat/add-tests branch February 26, 2024 20:58
Copy link
Contributor

@Antonboom Antonboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐌

pkg/lint/lintersdb/enabled_set_test.go Show resolved Hide resolved
pkg/lint/lintersdb/enabled_set_test.go Show resolved Hide resolved
pkg/lint/lintersdb/validator_test.go Show resolved Hide resolved
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@ldez ldez added this to the next milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Continuous integration, tests and other checks enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants