Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add test on ExcludeRule and SeverityRule #4420

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 27, 2024

When working on #4419, I saw that those validation methods were not tested.
And I find a bug when using path and path-except at the same time.

@ldez ldez added enhancement New feature or improvement area: tests Continuous integration, tests and other checks labels Feb 27, 2024
pkg/config/severity_test.go Show resolved Hide resolved
pkg/config/severity_test.go Outdated Show resolved Hide resolved
pkg/config/severity_test.go Show resolved Hide resolved
pkg/config/issues_test.go Outdated Show resolved Hide resolved
pkg/config/issues_test.go Show resolved Hide resolved
@ldez ldez merged commit 3452e2e into golangci:master Feb 27, 2024
12 checks passed
@ldez ldez deleted the feat/add-tests branch February 27, 2024 13:57
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@ldez ldez added this to the next milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Continuous integration, tests and other checks enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants