fix: move show-stats field from run to output #4439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
topic: cleanup
alexandear
approved these changes
Mar 2, 2024
ldez
changed the title
ldez
force-pushed
the
fix/move-show-stats
branch
from
3093371 to
ef2fd46
Compare
Antonboom
reviewed
Mar 6, 2024
| c.log.Warnf("The configuration option `run.show-stats` is deprecated, please use `output.show-stats`") | ||
| } | ||
|
|
||
| if !c.cfg.Run.ShowStats && !c.cfg.Output.ShowStats { |
There was a problem hiding this comment.
de morgan cosmetic:
if !(c.cfg.Run.ShowStats || c.cfg.Output.ShowStats) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the review of the PR about
show-statsI missed that the value was not in the right structure.This PR deprecated the old
run.show-stats, and replaced it withoutput.show-stats.The flag
--show-statsis not impacted, it's only about the file configuration.The old
run.show-statsstill works but with a deprecation log message.