Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: adjust replacement msg for nosnakecase #4443

Merged

Conversation

alexandear
Copy link
Member

The PR changed replacement string for the deprecated nosnakecase linter from revive(var-naming) to revive 'var-naming' to be consistent with the replacement string govet 'fieldalignment' for maligned.

Before:

❯ golangci-lint run -E nosnakecase -E maligned -v --disable-all --no-config

WARN [runner] The linter 'nosnakecase' is deprecated (since v1.48.1) due to: The repository of the linter has been deprecated by the owner. Replaced by revive(var-naming). 
WARN [runner] The linter 'maligned' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. Replaced by govet 'fieldalignment'. 

After:

❯ ./golangci-lint run -E nosnakecase -E maligned -v --disable-all --no-config

WARN [runner] The linter 'nosnakecase' is deprecated (since v1.48.1) due to: The repository of the linter has been deprecated by the owner. Replaced by revive 'var-naming'. 
WARN [runner] The linter 'maligned' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. Replaced by govet 'fieldalignment'. 

@ldez ldez self-requested a review March 3, 2024 13:51
@ldez ldez changed the title docs: adjust replacement msg for nosnakecase dev: adjust replacement msg for nosnakecase Mar 3, 2024
@ldez ldez added linter: update Update the linter implementation inside golangci-lint enhancement New feature or improvement labels Mar 3, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 9b560aa into golangci:master Mar 3, 2024
12 checks passed
@ldez ldez added this to the next milestone Mar 4, 2024
@alexandear alexandear deleted the docs-adjust-nostakecase-deprecated branch April 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants