chore: simplify comparators #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/simpify-comparators
branch
2 times, most recently
from
812cee7 to
f958bd5
Compare
ldez
force-pushed
the
feat/simpify-comparators
branch
from
f958bd5 to
905f4b7
Compare
ldez
force-pushed
the
feat/simpify-comparators
branch
from
52294b9 to
f84c4a5
Compare
alexandear
approved these changes
Mar 13, 2024
alexandear
reviewed
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all comparator implementations with one (
comparator) and simple functions.Less code but the same behavior.