-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to strictly follow Go autogenerated file convention #4507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would you like to deprecate the old variant at some point? It feels like supporting anything that is not the Go convention is a bad idea and if you want to do that it would make more sense to use skip-dirs
or skip-files
but I also see the convenience keeping it and having the strict version as opt-in.
Maybe just change the default (but it's breaking), because I think some people rely on that.
I think |
The current autogenerated file detection is very lax and it's expected (#48, #72).
But in some cases, this can be a problem.
Then I added an option to strictly follow Go autogenerated file convention.
The strict mode can be extended with simple
run.skip-dirs
orrun.skip-files
.One commit, one change.
Fixes #4506
Fixes #2254