-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new output.formats file configuration syntax #4521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
New feature or improvement
area: config
Related to .golangci.yml and/or cli options
area: output
Related to issue output
labels
Mar 17, 2024
ldez
force-pushed
the
feat/output-formats
branch
from
March 17, 2024 10:38
eeb37d7
to
977a370
Compare
ldez
force-pushed
the
feat/output-formats
branch
from
March 17, 2024 11:10
977a370
to
94547ea
Compare
bombsimon
approved these changes
Mar 17, 2024
ldez
force-pushed
the
feat/output-formats
branch
from
March 17, 2024 22:10
d8cdeac
to
3e1c8ce
Compare
Antonboom
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Anton Telyshev <anton.telishev@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: config
Related to .golangci.yml and/or cli options
area: output
Related to issue output
enhancement
New feature or improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the syntax inside the configuration file to specify output formats.
The previous syntax has been defined when only the format type was an option.
However, the syntax has evolved to support output paths and multiple formats.
This is a flag syntax friendly but not a file syntax friendly.
I propose this new syntax:
The CLI flag keeps the same syntax.
To keep this new option compatible with the GitHub Action, the CLI must override the configuration file.
The previous field
output.format
is deprecated and works as before but with a warning.