Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are using this kind of configuration:
An error will appear:
This a new problem related to the previous refactor: the validation doesn't happen at the same time as before (and it's a good thing).
Inside the
govet
implementation, the passshadow
is added toenable
whencheck-shadowing
is true, but as it's a pointer to the configuration, then the real configuration is also modified.Note:
check-shadowing
is deprecated inside the code but not with a warning since 2019.I will create another PR to deprecate this option.