Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: isolates the code borrowed from Go #5100

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 2, 2024

Isolates the code borrowed from Go to internal/go/:
- moves package from internal/cache to internal/go/cache
- moves package from internal/mmap to internal/go/mmap
- moves package from internal/quoted to internal/go/quoted
- moves package from internal/robustio to internal/go/robustio
- moves package from internal/testenv to internal/go/testenv

Cuts direct dependency to internal/go/cache except for internal/pkgcache:

  • accesses to the cache are made only through internal/pkgcache

Renames internal/pkgcache to internal/cache.

Updates the documentation history of the internal packages.

1 commit 1 change: it's easier to review the changes by commit because the moves and renaming confuse git diff.

Follows #5098

@ldez ldez added topic: cosmetic changes contain cosmetic improvements area: cache labels Nov 2, 2024
@ldez ldez added this to the next milestone Nov 2, 2024
@ldez ldez force-pushed the feat/isolate-borrowed-go-code branch from 7ac45dc to 46e8c03 Compare November 2, 2024 21:08
@ldez ldez requested a review from bombsimon November 4, 2024 19:57
@ldez ldez merged commit 34209d7 into golangci:master Nov 5, 2024
15 checks passed
@ldez ldez deleted the feat/isolate-borrowed-go-code branch November 5, 2024 10:30
@ldez ldez modified the milestones: next, v1.62 Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cache topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants