Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format of junit xml output to mark failures as such #632

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

glenjamin
Copy link
Contributor

As noted in #557 (comment) - the current Junit xml output treats each lint issue as a passing test.

This PR expands the details and shuffles things around so that it shows up as a failing test instead.

There didn't seem to be any automated tests for this functionality, so I haven't added any new ones.

Here's a sample of what that looks like with CircleCI's junit parsing
https://circleci.com/gh/glenjamin/golangci-lint/5

I don't know which other popular tools do junit parsing like this - I based this implementation loosely off https://github.com/eslint/eslint/blob/master/lib/cli-engine/formatters/junit.js

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2019

CLA assistant check
All committers have signed the CLA.

@glenjamin
Copy link
Contributor Author

I've inspected the SVG, and I can't see any difference - I'm not sure why this would have changed on my branch.

@Helcaraxan
Copy link
Contributor

@glenjamin - See #625 for the solution. Once that fix is merged all latests PR can be rebased on top of the fresh master and go green.

@jirfag jirfag merged commit 97fcafd into golangci:master Sep 10, 2019
@jirfag
Copy link
Member

jirfag commented Sep 10, 2019

thank you!

@ldez ldez added this to the v1.18 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants