Update format of junit xml output to mark failures as such #632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #557 (comment) - the current Junit xml output treats each lint issue as a passing test.
This PR expands the details and shuffles things around so that it shows up as a failing test instead.
There didn't seem to be any automated tests for this functionality, so I haven't added any new ones.
Here's a sample of what that looks like with CircleCI's junit parsing
https://circleci.com/gh/glenjamin/golangci-lint/5
I don't know which other popular tools do junit parsing like this - I based this implementation loosely off https://github.com/eslint/eslint/blob/master/lib/cli-engine/formatters/junit.js