Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: fix the timestamp in go.mod #650

Closed
wants to merge 1 commit into from
Closed

all: fix the timestamp in go.mod #650

wants to merge 1 commit into from

Conversation

Stebalien
Copy link

Go 1.13 actually cares if these timestamps are correct. See:
https://tip.golang.org/doc/go1.13#version-validation

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2019

CLA assistant check
All committers have signed the CLA.

@Stebalien Stebalien changed the title all: fix the timestamp on go-critic all: fix the timestamp in go.mod Aug 22, 2019
Go 1.13 actually cares if these timestamps are correct. See:
https://tip.golang.org/doc/go1.13#version-validation
golang.org/x/sys v0.0.0-20190312061237-fead79001313 // indirect
golang.org/x/tools v0.0.0-20190521203540-521d6ed310dd
golang.org/x/tools v0.0.0-20190719005602-e377ae9d6386
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get go to not update this.

gopkg.in/airbrake/gobrake.v2 v2.0.9 // indirect
gopkg.in/gemnasium/logrus-airbrake-hook.v2 v2.1.2 // indirect
gopkg.in/yaml.v2 v2.2.1
mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed
mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b // indirect
mvdan.cc/unparam v0.0.0-20190124213536-fbb59629db34
mvdan.cc/unparam v0.0.0-20190720180237-d51796306d8f
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@Stebalien
Copy link
Author

Dup of #643.

@Stebalien Stebalien closed this Aug 22, 2019
@Stebalien Stebalien deleted the fix/go-critic-timestamp branch August 22, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants