Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update limitrequests.md #1287

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Update limitrequests.md #1287

merged 2 commits into from
Mar 6, 2024

Conversation

animir
Copy link
Contributor

@animir animir commented Nov 11, 2023

Use ioredis package

@animir
Copy link
Contributor Author

animir commented Feb 27, 2024

@goldbergyoni Above lint error isn't related to this PR.
We should update to ioredis package in the example since previously used redis package has changed how they create Redis client. It is more complicated now and not the best for simple example like that. Current example in master branch doesn't work with the latest redis package. With ioredis it works for any version.

@goldbergyoni
Copy link
Owner

@animir Great point here, thanks!

And... congrats for the new release of node-rate-limiter-flexible 🥳

Let's make some article or YouTube about rate limiting some day

@goldbergyoni goldbergyoni merged commit 54f8732 into goldbergyoni:master Mar 6, 2024
1 of 2 checks passed
@animir
Copy link
Contributor Author

animir commented Mar 6, 2024

@goldbergyoni Hi, thanks!
There are some articles about rate limiting and brute-force protection on Medium I wrote a couple of years ago https://medium.com/@animirr
I see you do have YouTube channel. It may be interesting to collaborate.
I'll make sure to email you to continue this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants