Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation #577

Merged
merged 3 commits into from
Oct 20, 2019
Merged

Spanish translation #577

merged 3 commits into from
Oct 20, 2019

Conversation

oliverll1
Copy link

I changed some of the words and phrasing to make it more appealing to hispanic readers, this way it doesnt sound like it was translated but natively written on spanish

@js-kyle
Copy link
Contributor

js-kyle commented Oct 15, 2019

@ZyBax looks great, thank you! I will leave it here for a short time to see if any of our other Spanish contributors can review, otherwise it looks good

@js-kyle
Copy link
Contributor

js-kyle commented Oct 15, 2019

@all-contributors-bot please add @ZyBax for translation

@allcontributors
Copy link
Contributor

@js-kyle

I've put up a pull request to add @ZyBax! 🎉

# ¡Bienvenido! 3 cosas que necesitas saber primero:
**1. Cuando lees aquí, lees docenas de los mejores artículos de Node.JS -** este es un resumen y conservación del contenido mejor clasificado de las mejores prácticas de NodeJS
# ¡Bienvenido! 3 cosas que deberias saber primero:
**1. Aquí encontraras docenas de los mejores artículos sobre Node.JS -** este es un resumen y conservación del contenido mejor clasificado de las mejores prácticas de NodeJS
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing accent on "encontrarás"! Otherwise LGTM 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, just fixed it, thanks

@js-kyle js-kyle merged commit 5228bd3 into goldbergyoni:spanish-translation Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants