Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major breaking issue with preventDefault added to global document click handler #1025

Closed
xdumaine opened this issue Aug 24, 2018 · 3 comments

Comments

@xdumaine
Copy link

310736b

This commit is breaking clicks (namely clicking links (anchor tags)) in my app in some situations. Basically, somehow, the onended function is never invoked, and the click handler never gets removed, and then my app is totally busted. I'm trying to figure how exactly how or when this happen, but if you have any tips, I'd love to hear them. For now, I have to pin howler back to an earlier version.

@matthewoates
Copy link

I've noticed this myself, and was surprised to find that howler was to blame. I'm able to reproduce this consistently.

On OSX with Chrome:

  • visit web app
  • hit reload (actually click the refresh button), wait for page to finish loading and don't click on anything
  • click on a link

expected: link works
actual: nothing happens

Note that this only happens for the first click during the page session, and this does not happen if you use CMD + R to reload.

@matthewoates
Copy link

@xdumaine a temporary work around is to use v2.0.13

@goldfire
Copy link
Owner

Thanks, this has now been fixed and I'll get a v2.0.15 out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants