-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix play to avoid starting from beginning after pause #1102
Conversation
When playing a 'paused' howl, we were instanciating a new `sound` every time. Instead we should use the existing `sound` if: - `_paused === true` - `_ended === false` This basically rollbacks this commit be4e445#diff-1e099b745600c69cbaacbe86736975fc fixes #1101
This causes #1060 to happen again, which is why that code was removed in the first place. |
Interesting, but I don't understand the #1060 bug var sound = new Howl({
src: [intro, backAudio],
... shouldn't we assume |
Both should now be fixed with d22ddcf, but let me know if it still isn't working for you. |
Perfect thank you ! I'll take a look |
yes I confirm it's working thanks @goldfire ! |
@goldfire do you plan on releasing this soon? |
@clementdevos Yes, we've got a big update to one of our games today and then I plan on getting a 2.1.1 release out either today or tomorrow. |
When playing a 'paused' howl, we were instanciating a new
sound
everytime.
Instead we should use the existing
sound
if:_paused === true
_ended === false
This basically rollbacks this commit be4e445#diff-1e099b745600c69cbaacbe86736975fc
fixes #1101