reset audio context noAudio to false when unload #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1441,6 +1441,9 @@ | |||
| delete cache[self._src]; | |||
| } | |||
|
|
|||
| // Clear global errors | |||
| Howler.noAudio = false | |||
There was a problem hiding this comment.
just needs a semicolon on the end of this.
There was a problem hiding this comment.
added now. you may squash the two commits.
garethwhittaker
pushed a commit
to tombolaltd/howler.js
that referenced
this pull request
Sep 27, 2016
|
I'm also unloading the Howl instance on a failed load, subsequently leading to the same issue: "No audio support." This fix works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our case is using multiple audios on web page.
I unload a Howl object when the audio load failed. I found that noAudio not reset when unload method invoked. So I set global
Howler.noAudioto false, otherwise others created audio object cannot play.