Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update howler.core.js #675

Merged
merged 1 commit into from
Dec 24, 2016
Merged

Update howler.core.js #675

merged 1 commit into from
Dec 24, 2016

Conversation

LIU9293
Copy link
Contributor

@LIU9293 LIU9293 commented Dec 21, 2016

Sometimes, users want to change the playlist, so i unload the howler instance and create a new one, but when i unload the instance, the '_onend' event listener will trigger every time.

In my case, the next method will affect the playlist too, so it bother me a lot. I think when people unload the instance, they do not want affect anything, so why emit the 'end' event ?

If you have some better idea, please let me know, thank you.

@goldfire goldfire merged commit 96e8a96 into goldfire:master Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants