Fix scratch buffer (iOS memory leak fix) not working since 982c0aa #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching that! However, can you just make the change to |
|
Hi again, sorry this slipped my mind for a bit! I've reverted the non-src changes. |
legion19191
reviewed
Dec 6, 2017
| @@ -1910,10 +1910,10 @@ | |||
| _cleanBuffer: function(node) { | |||
| var self = this; | |||
There was a problem hiding this comment.
you could have just changed var self = Howler instead of self in two other spots
ringcrl
pushed a commit
to ringcrl/howler.js
that referenced
this pull request
Apr 21, 2019
Fix scratch buffer (iOS memory leak fix) not working since 982c0aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_scratchBufferproperty was moved to theHowlerGlobalinstance (Howler) but theHowlinstances still looked forself._scratchBufferwhen cleaning up. I just changed that cleanup method to refer toHowler._scratchBufferinstead.