Market scan #972
Merged
Market scan #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgordel
reviewed
Jun 13, 2024
src/market/scan/scanned-proposal.ts
Outdated
| }; | ||
| } | ||
|
|
||
| getProviderInfo() { |
There was a problem hiding this comment.
maybe we should replace getProviderInfo() with get provider, for consistency.
|
|
||
| public scan(spec: ScanSpecification): Observable<ScannedOffer> { | ||
| const ac = new AbortController(); | ||
| return new Observable((observer) => { |
There was a problem hiding this comment.
what do you think about moving this part to YagnaAPI, we have a very similar implementation when fetching batch results here:
golem-js/src/shared/yagna/yagnaApi.ts
Line 120 in d2c5d56
There was a problem hiding this comment.
TBF I think observeBatchExecResults should be moved to activity api, it's probably a relic from the time before we had api adapters. I'll leave it for now
grisha87
suggested changes
Jul 1, 2024
grisha87
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires yagna 0.15.2-rc1Requires yagna 0.15.2 (lastest stable release)
feel free to modify
examples/advanced/scan.tsto see what's possible