Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vg/fonts: support //go:embed directives #637

Closed
sbinet opened this issue Sep 3, 2020 · 1 comment · Fixed by #728
Closed

vg/fonts: support //go:embed directives #637

sbinet opened this issue Sep 3, 2020 · 1 comment · Fixed by #728

Comments

@sbinet
Copy link
Member

sbinet commented Sep 3, 2020

as mentioned in golang/go#41191, Go will probably support //go:embed directives as designed in:

we should probably migrate/prepare for this new feature (when it lands)
and make use of it in vg/fonts.
@kortschak
Copy link
Member

SGTM

sbinet added a commit to sbinet-gonum/plot that referenced this issue Aug 13, 2021
@sbinet
vg/{fonts,vgpdf}: remove vg/fonts package
9fca7f4 
Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Fixes gonum#696.
Fixes gonum#637.
sbinet added a commit to sbinet-gonum/plot that referenced this issue Aug 17, 2021
@sbinet
vg/{fonts,vgpdf}: remove vg/fonts package
a6e7cfd 
Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Fixes gonum#696.
Fixes gonum#637.
@sbinet sbinet mentioned this issue Aug 17, 2021
Merged
sbinet added a commit that referenced this issue Aug 19, 2021
@sbinet
vg/{fonts,vgpdf}: remove vg/fonts package
d08bae0 
Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Fixes #696.
Fixes #637.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vg/{fonts,vgpdf}: remove vg/fonts package sbinet-gonum/plot
2 participants
@kortschak @sbinet