Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade go 1.20 -> 1.23.1, complete colorizef migration, unify output consts #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sheikhrachel
Copy link

@sheikhrachel sheikhrachel commented Sep 11, 2024

Purpose

  • Removes redundant import alias for colorful that can be referenced from the import path
  • in box.go, changes options -> boxOpts to avoid collision with the internal options & boxOptions structs in the neat package
  • in table.go, changes options -> opts to avoid collision with the options struct defined in the same file
  • Adds consts to remove the dependency on handwriting commonly used output strings (ex. node tags like "!!str" or "emptyStructures")
  • Completes the deprecation of colorize -> colorizef by converting references, and adding a nil check in colorizef to skip the fmt.Sprintf call if the caller doesn't need to format a string
    • Additionally, adds a docstring to the function to surface this context for callers
  • Updates the project's Go version to 1.23.1

…y output consts

Signed-off-by: Rachel Sheikh <sheikhrachel97@gmail.com>
@sheikhrachel
Copy link
Author

I've run the test suite locally to confirm continued expected behaviors after the minor version upgrade

Additionally, the current GHA workflows already leverage a go 1.23.x version when running their tasks

@sheikhrachel sheikhrachel changed the title [chore] upgrade go 1.20 -> 1.23.1, complete colorizef migration, unify output consts feat: upgrade go 1.20 -> 1.23.1, complete colorizef migration, unify output consts Sep 12, 2024
@sheikhrachel
Copy link
Author

bump on this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant