Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.1 and 3.2 to the CI matrix #404

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

petergoldstein
Copy link

Runs green on my fork.

@gonzalo-bulnes
Copy link
Owner

Hi @petergoldstein !

Sorry about that, I missed the notification it seems.

Is there a particular reason why you'd like to test both under Ruby 3.1 and 3.2?
I'm asking because I'd be tempted to replace 3.0 by 3.2.

I keep a few older versions to ensure I keep running regression tests on older Rails versions (which is debatable, but since I haven't officially broken a 2.x.x tag yet, I want to make sure he version number doesn't lie). I'm otherwise a bit conscious of running long builds (in energy ⚡, not time) for little added benefit. I suppose I can be convinced otherwise, it's not like there is a lot of activity around the gem these days 🙂

Any thoughts?

@petergoldstein
Copy link
Author

Because they are different Ruby versions, don't have compatible behavior guarantees, and behave differently in a variety of circumstances. The fact that a gem runs under 3.2 (or 3.0) gives you only a little confidence regarding 3.1. Generally speaking I prefer CI to run each "minor" version of Ruby since, in practice, each of these versions is a major version in the semantic versioning sense.

@gonzalo-bulnes
Copy link
Owner

Fair enough. And I don't think the build runs often enough for the extra steps to be a problem. 👍

@gonzalo-bulnes gonzalo-bulnes self-requested a review September 9, 2023 23:01
Copy link
Owner

@gonzalo-bulnes gonzalo-bulnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the actions/checkout upgrade 👍

  • only tun the latest Rails agsinst Ruby (head) 👍
  • add all "minor" Ruby versions in the 3.x series 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants