Add approximation to current SecureDrop theme #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spacing is difficult to render in a QWizard, and the stylesheets are intentionally left without class names :(
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an exploration into the theming capabilities of the
QWizardclass.I don't find it easy to work with... internal elements are not easy to identify for targeting, and some QSS properties behave unexpectedly.
Example of unexpected stylesheet behavior
>p>For example, when setting margins, a background color, and a border at the top level of the wizard, the background (red in the image below) extends beyond the borders (yellow in the image below). The `#AAA` element is the `QWizard` in this example. 🙁Anyhow, this is the result of a time-boxed exercise.