fix: validate custom date filter config granularities #5720
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbenes
reviewed
Dec 17, 2024
| @@ -12,6 +12,14 @@ import { | |||
| idRef, | |||
| } from "@gooddata/sdk-model"; | |||
|
|
|||
| const dateFilterGranularity: DateFilterGranularity[] = [ | |||
There was a problem hiding this comment.
just wandering if we could use this model for validation? https://github.com/gooddata/gooddata-ui-sdk/blob/master/libs/sdk-model/src/dateFilterConfig/index.ts#L72-L87 (but note that the list item does not match exactly)
There was a problem hiding this comment.
Updated it to use existing method - isDateFilterGranularity
NestorEncinas
force-pushed
the
nen-lx-706
branch
from
b2c4d5f to
f5c30f3
Compare
risk: low JIRA: LX-706
NestorEncinas
force-pushed
the
nen-lx-706
branch
from
f5c30f3 to
6a49bde
Compare
pbenes
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
risk: low
JIRA: LX-706
Important
Please, don't forget to run
rush changefor the commits that introduce new features 🙏Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands: