Replace get_default_test_tmpdir() with create_tempdir().
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_642266121
branch
2 times, most recently
from
12ec4df
to
b1317e6
Compare
copybara-service
bot
changed the title
absltest.get_default_test_tmpdir() is widely used in our code base, but it'sget_default_test_tmpdir() with create_tempdir().
copybara-service
bot
force-pushed
the
test_642266121
branch
from
b1317e6
to
4c46dca
Compare
copybara-service
bot
force-pushed
the
test_642266121
branch
from
4c46dca
to
48d1d31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
get_default_test_tmpdir()withcreate_tempdir().absltest.get_default_test_tmpdir()is widely used in our code base, but it'sgot some problems like not respecting the value of
FLAGS.test_tmpdir. Thischange replaces it with
self.create_tempdir()inadb_call_parser_test.py.Other changes will follow for other test files.