Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Spades #1242

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Updates to Spades #1242

merged 6 commits into from
Jul 30, 2024

Conversation

i-Madsen
Copy link
Contributor

Now can get/set scores and set a bonus reward for winning/losing overall game to returns.

Now can get/set scores and set a bonus reward for winning/losing overall game to returns.
@lanctot
Copy link
Collaborator

lanctot commented Jun 26, 2024

Hi @i-Madsen, thanks for the updates!

Can you pull changes from master and merge them into your branch? I had to make some cosmetic changes to your code to adhere to the required style. (If you can keep these persistent and apply them elsewhere too, that'd be great.)

Once any conflicts are resolved, please push the merge commit.

@lanctot
Copy link
Collaborator

lanctot commented Jun 26, 2024

Also, note: I will soon not have access to the Internet for the next 8-10 days.. so apologies for any delays in responses.

@i-Madsen
Copy link
Contributor Author

i-Madsen commented Jul 2, 2024

Ok, think I've got it all merged correctly and pushed once you get back. Let me know if I missed anything.

Edit: I do see it's failing checks on here, but I'm not what's different that's causing it.

@lanctot
Copy link
Collaborator

lanctot commented Jul 16, 2024

Hi @i-Madsen,

Ok the CI is fixed now as of #1250

Can you pull from master and push the merge commit?

@i-Madsen
Copy link
Contributor Author

@lanctot Ok, should be merged now.

@lanctot
Copy link
Collaborator

lanctot commented Jul 21, 2024

@lanctot Ok, should be merged now.

Ok seems there are some test failures for legitimate reasons (a function is marked void but I guess it's returning a bool?) Can you take a look and push a fix?

@i-Madsen
Copy link
Contributor Author

@lanctot Looks like it's all passing now (not sure how I missed that before).

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Jul 26, 2024
@lanctot lanctot merged commit 5063bb3 into google-deepmind:master Jul 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants