Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge to Edge new api #16

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Edge to Edge new api #16

merged 2 commits into from
Mar 5, 2024

Conversation

android-dev-lxl
Copy link
Collaborator

No description provided.

Copy link

@johnshea johnshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@Jaehwa-Noh Jaehwa-Noh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I'd found your PR as study new edge-to-edge, and I suggested some changes at your code to work properly.

@android-dev-lxl android-dev-lxl requested review from Jaehwa-Noh and removed request for Jaehwa-Noh March 5, 2024 21:01
Copy link

@Jaehwa-Noh Jaehwa-Noh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you to accept my suggestion.
Look good to me!

@android-dev-lxl android-dev-lxl merged commit 4f5821b into main Mar 5, 2024
1 check passed
@android-dev-lxl android-dev-lxl deleted the main-e2e-new-api branch March 5, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants