Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some unit test cases #159

Merged
merged 2 commits into from
May 29, 2024
Merged

Add some unit test cases #159

merged 2 commits into from
May 29, 2024

Conversation

hsubox76
Copy link
Collaborator

For generatecontent, test that the field is passed to makeRequest, that it's overrideable by individual methods, and the same for chat.sendMessage.

@hsubox76 hsubox76 marked this pull request as ready for review May 29, 2024 20:47
Copy link
Collaborator

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@hsubox76 hsubox76 merged commit e899b91 into lm-add-responseschema May 29, 2024
4 checks passed
@hsubox76 hsubox76 deleted the ch-response-tests branch May 29, 2024 20:52
lahirumaramba added a commit that referenced this pull request May 29, 2024
* Add JSON Schema Support

* Add unit tests

* Add changeset

* update changeset

* Add some unit test cases (#159)

---------

Co-authored-by: Christina Holland <chholland@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants