Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up iTests for CI #163

Merged
merged 2 commits into from
May 31, 2024
Merged

Clean up iTests for CI #163

merged 2 commits into from
May 31, 2024
+6 −115

Conversation

DellaBitta
Copy link
Collaborator

@DellaBitta DellaBitta commented May 31, 2024 •
edited
Loading

Change iTests so that they're ready for CI again.

  • Remove tests that detected status failures on harmful content. These questions now have textual responses. I attempted to find another means to detect the response is a rejected one (a code or status in the response) but there doesn't seem to be a metric that flags it as a harmful question.
  • Change the wording of one of the questions "How many people live there?" as sometimes it wouldn't pass the service's safety checks. This question is now "How many people live in that city?".

This is a change to our tests only, so no Changeset is required.

@DellaBitta
Remove test which sometimes trigger safety errors.
d1bcbc9 
The test would ask about a city in Oregon and follow up with "How many people live there?" A question, when taken out of context,  is one that could trigger safety concerns.
@DellaBitta
Remove blocked tests.
c84504c 
These tests once returned an error code but now respond with text that describes why the service has refused to answer the tests.
@DellaBitta DellaBitta requested a review from hsubox76 May 31, 2024 18:35
hsubox76
hsubox76 approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LG!

@DellaBitta DellaBitta marked this pull request as ready for review May 31, 2024 19:04
@DellaBitta DellaBitta merged commit 40daf95 into main May 31, 2024
4 checks passed
@DellaBitta DellaBitta deleted the ddb-remove-harm-itest branch May 31, 2024 19:05
@melvinchia3636 melvinchia3636 mentioned this pull request Jul 10, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Jul 10, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Jul 10, 2024
Closed
@leoo1992 leoo1992 mentioned this pull request Jul 10, 2024
Merged
This was referenced Jul 10, 2024
Merged
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Jul 18, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Jul 18, 2024
Closed
@Anomaly-1 Anomaly-1 mentioned this pull request Jul 18, 2024
Open
@leoo1992 leoo1992 mentioned this pull request Jul 19, 2024
Merged
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Jul 21, 2024
Closed
@Anomaly-1 Anomaly-1 mentioned this pull request Jul 23, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Jul 23, 2024
Closed
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Jul 23, 2024
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Jul 23, 2024
Open
This was referenced Aug 1, 2024
Open
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 6, 2024
Open
@nestorzamili nestorzamili mentioned this pull request Aug 6, 2024
Merged
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 6, 2024
Open
@rizwan-r-r rizwan-r-r mentioned this pull request Aug 12, 2024
Merged
@Anomaly-1 Anomaly-1 mentioned this pull request Aug 15, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 15, 2024
Open
@paulorezende007 paulorezende007 mentioned this pull request Aug 21, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Aug 25, 2024
Open
@melvinchia3636 melvinchia3636 mentioned this pull request Sep 4, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 7, 2024
Open
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @hsubox76