-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce duplicate in integration tests #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
force-pushed
the
sethvargo/integ
branch
from
November 10, 2022 16:38
4793f30
to
3019071
Compare
verbanicm
reviewed
Nov 10, 2022
verbanicm
reviewed
Nov 10, 2022
sethvargo
force-pushed
the
sethvargo/integ
branch
5 times, most recently
from
November 10, 2022 20:22
b0adba6
to
310210f
Compare
As part of the 1.0 release, we removed service_account support from setup-gcloud, but many of the integration tests were actually duplicates now, since they used to test service_account. This updates the integration tests to run all the tests in a single job (reducing the number of times we install NPM packages and download gcloud).
sethvargo
force-pushed
the
sethvargo/integ
branch
from
November 10, 2022 21:34
310210f
to
980685c
Compare
verbanicm
approved these changes
Nov 10, 2022
Merged
sethvargo
pushed a commit
that referenced
this pull request
Feb 3, 2023
## What's Changed * Reduce duplicate in integration tests by @sethvargo in #591 * chore(deps): bump sinon from 14.0.2 to 15.0.0 by @dependabot in #596 * chore(deps): bump qs and express in /example-workflows/cloud-build by @dependabot in #599 * Update CI and deps by @sethvargo in #603 * Note that metrics export should not be copied by @sethvargo in #604 * Add support for specifying version constraints by @sethvargo in #612 **Full Changelog**: v1.0.1...10b5bd2
kodiakhq bot
referenced
this pull request
in cloudquery/cloudquery
Feb 28, 2024
…16953) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google-github-actions/setup-gcloud](https://togithub.com/google-github-actions/setup-gcloud) | action | major | `v0.7.0` -> `v2.1.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google-github-actions/setup-gcloud (google-github-actions/setup-gcloud)</summary> ### [`v2.1.0`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v2.1.0) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v2.0.1...v2.1.0) #### What's Changed - Update deps by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/677](https://togithub.com/google-github-actions/setup-gcloud/pull/677) - Release: v2.1.0 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/678](https://togithub.com/google-github-actions/setup-gcloud/pull/678) **Full Changelog**: google-github-actions/setup-gcloud@v2...v2.1.0 ### [`v2.0.1`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v2.0.1) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v2.0.0...v2.0.1) #### What's Changed - Update README and CI to use latest version by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/665](https://togithub.com/google-github-actions/setup-gcloud/pull/665) - Don't warn when version is "latest" by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/669](https://togithub.com/google-github-actions/setup-gcloud/pull/669) - Only warn when there are no authentications by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/671](https://togithub.com/google-github-actions/setup-gcloud/pull/671) - Fix edge case when gcloud is not installed at all by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/672](https://togithub.com/google-github-actions/setup-gcloud/pull/672) - Rename test step to a more accurate name by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/673](https://togithub.com/google-github-actions/setup-gcloud/pull/673) - Release: v2.0.1 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/674](https://togithub.com/google-github-actions/setup-gcloud/pull/674) **Full Changelog**: google-github-actions/setup-gcloud@v2...v2.0.1 ### [`v2.0.0`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v2.0.0) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v1.1.1...v2.0.0) **:warning: This version requires Node 20 or later!** #### What's Changed - dependabot: only do security updates by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/643](https://togithub.com/google-github-actions/setup-gcloud/pull/643) - update all deps by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/644](https://togithub.com/google-github-actions/setup-gcloud/pull/644) - Update deps to Node 20 by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/653](https://togithub.com/google-github-actions/setup-gcloud/pull/653) - Upgrade setup-cloud-sdk package by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/656](https://togithub.com/google-github-actions/setup-gcloud/pull/656) - Add CI for release branches by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/661](https://togithub.com/google-github-actions/setup-gcloud/pull/661) - Update and drop unnecessary deps by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/662](https://togithub.com/google-github-actions/setup-gcloud/pull/662) - Release: v2.0.0 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/664](https://togithub.com/google-github-actions/setup-gcloud/pull/664) **Full Changelog**: google-github-actions/setup-gcloud@v1...v2.0.0 ### [`v1.1.1`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v1.1.1) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v1.1.0...v1.1.1) #### What's Changed - Fix docs about component installation for system-provided by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/615](https://togithub.com/google-github-actions/setup-gcloud/pull/615) - chore: update dependencies (automated) by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/623](https://togithub.com/google-github-actions/setup-gcloud/pull/623) - Switch to pull non-secret values from env by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/624](https://togithub.com/google-github-actions/setup-gcloud/pull/624) - Drop example workflows by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/627](https://togithub.com/google-github-actions/setup-gcloud/pull/627) - Add warning about `skip_install` by [@​ethanmdavidson](https://togithub.com/ethanmdavidson) in [https://github.com/google-github-actions/setup-gcloud/pull/630](https://togithub.com/google-github-actions/setup-gcloud/pull/630) - chore(deps): bump yaml from 2.2.1 to 2.2.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google-github-actions/setup-gcloud/pull/629](https://togithub.com/google-github-actions/setup-gcloud/pull/629) - Update README.md by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/631](https://togithub.com/google-github-actions/setup-gcloud/pull/631) - Add support note by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/634](https://togithub.com/google-github-actions/setup-gcloud/pull/634) - chore: update dependencies (automated) by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/637](https://togithub.com/google-github-actions/setup-gcloud/pull/637) - Release: v1.1.1 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/638](https://togithub.com/google-github-actions/setup-gcloud/pull/638) #### New Contributors - [@​ethanmdavidson](https://togithub.com/ethanmdavidson) made their first contribution in [https://github.com/google-github-actions/setup-gcloud/pull/630](https://togithub.com/google-github-actions/setup-gcloud/pull/630) **Full Changelog**: google-github-actions/setup-gcloud@v1.1.0...v1.1.1 ### [`v1.1.0`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v1.1.0) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v1.0.1...v1.1.0) #### What's Changed - Reduce duplicate in integration tests by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/591](https://togithub.com/google-github-actions/setup-gcloud/pull/591) - chore(deps): bump sinon from 14.0.2 to 15.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google-github-actions/setup-gcloud/pull/596](https://togithub.com/google-github-actions/setup-gcloud/pull/596) - chore(deps): bump qs and express in /example-workflows/cloud-build by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google-github-actions/setup-gcloud/pull/599](https://togithub.com/google-github-actions/setup-gcloud/pull/599) - Update CI and deps by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/603](https://togithub.com/google-github-actions/setup-gcloud/pull/603) - Note that metrics export should not be copied by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/604](https://togithub.com/google-github-actions/setup-gcloud/pull/604) - Add support for specifying version constraints by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/612](https://togithub.com/google-github-actions/setup-gcloud/pull/612) - Release: v1.1.0 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/613](https://togithub.com/google-github-actions/setup-gcloud/pull/613) **Full Changelog**: google-github-actions/setup-gcloud@v1.0.1...v1.1.0 ### [`v1.0.1`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v1.0.1) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v1.0.0...v1.0.1) #### What's Changed - fix: cleanup integration tests by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/582](https://togithub.com/google-github-actions/setup-gcloud/pull/582) - fix: docker integration test by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/583](https://togithub.com/google-github-actions/setup-gcloud/pull/583) - fix: suggest v1 instead of v0 by [@​KengoTODA](https://togithub.com/KengoTODA) in [https://github.com/google-github-actions/setup-gcloud/pull/584](https://togithub.com/google-github-actions/setup-gcloud/pull/584) - fix: update versions in examples by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/585](https://togithub.com/google-github-actions/setup-gcloud/pull/585) - Force authentication if GOOGLE_GHA_CREDS_PATH is set by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/587](https://togithub.com/google-github-actions/setup-gcloud/pull/587) - fix: update docs by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/588](https://togithub.com/google-github-actions/setup-gcloud/pull/588) - Release: v1.0.1 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/589](https://togithub.com/google-github-actions/setup-gcloud/pull/589) **Full Changelog**: google-github-actions/setup-gcloud@v1.0.0...v1.0.1 ### [`v1.0.0`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v1.0.0) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v0.7.0...v1.0.0) #### What's Changed - Document that WIF is supported for gsutil and bq now by [@​KengoTODA](https://togithub.com/KengoTODA) in [https://github.com/google-github-actions/setup-gcloud/pull/573](https://togithub.com/google-github-actions/setup-gcloud/pull/573) - feat: update for 1.0 release by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/580](https://togithub.com/google-github-actions/setup-gcloud/pull/580) - Release: v1.0.0 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/581](https://togithub.com/google-github-actions/setup-gcloud/pull/581) #### New Contributors - [@​KengoTODA](https://togithub.com/KengoTODA) made their first contribution in [https://github.com/google-github-actions/setup-gcloud/pull/573](https://togithub.com/google-github-actions/setup-gcloud/pull/573) **Full Changelog**: google-github-actions/setup-gcloud@v0.6.2...v1.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the 1.0 release, we removed service_account support from setup-gcloud, but many of the integration tests were actually duplicates now, since they used to test service_account. This updates the integration tests to run all the tests in a single job (reducing the number of times we install NPM packages and download gcloud).