Moves sorting to loadConfiguration.

google-marketing-solutions · Jun 28, 2024 · 65542ed · 65542ed
1 parent 0019dd9
commit 65542ed
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/frontend/src/app/ml-models/ml-model-form/ml-model-form.component.ts b/frontend/src/app/ml-models/ml-model-form/ml-model-form.component.ts
@@ -137,6 +137,11 @@ export class MlModelFormComponent implements OnInit {
     try {
       const mlModel = await this.mlModelsService.get(id);
       this.mlModel = plainToClass(MlModel, mlModel as MlModel);
+      this.mlModel.variables.sort((a: Variable, b: Variable) => {
+        const aCompare = `${a.role + a.source + a.name}`;
+        const bCompare = `${b.role + b.source + b.name}`;
+        return aCompare.localeCompare(bCompare);
+      });
       this.assignMlModelToForm();
     } catch (error) {
       if (error && error.status === 404) {
@@ -417,11 +422,6 @@ export class MlModelFormComponent implements OnInit {
         const dataset = this.value('bigQueryDataset');
         const ts = this.value('timespans');
         variables = await this.mlModelsService.getVariables(input, dataset, ts);
-        variables.sort((a: Variable, b: Variable) => {
-          const aCompare = `${a.role + a.source + a.name}`;
-          const bCompare = `${b.role + b.source + a.name}`;
-          return aCompare.localeCompare(bCompare);
-        });
         this.cachedVariables = variables;
         this.errorMessage = '';
         this.refreshVariables();