Use full path in tmp cache directory name to reduce likelihood of a c…

…onflict.

PiperOrigin-RevId: 676472711

android_world/utils/file_utils.py

@@ -19,6 +19,7 @@
 import datetime
 import os
 import random
+import re
 import shutil
 import string
 from typing import Iterator
@@ -302,7 +303,7 @@ def tmp_directory_from_device(
     FileNotFoundError: If the remote directory does not exist.
     RuntimeError: If there is an adb communication error.
   """
-  directory_name = os.path.split(device_path)[-1]
+  directory_name = re.sub(r"\W", "", device_path)
   tmp_directory = os.path.join(TMP_LOCAL_LOCATION, directory_name)
   logging.info(
       "Copying %s directory to local tmp %s", device_path, tmp_directory

android_world/utils/file_utils_test.py

@@ -84,16 +84,16 @@ def test_tmp_directory_from_device(
         ),
     )
 
-    tmp_local_directory = os.path.join(file_utils.TMP_LOCAL_LOCATION, 'dir')
+    tmp_local_directory = f'{file_utils.TMP_LOCAL_LOCATION}/remotedir'
     with file_utils.tmp_directory_from_device(
-        '/remote/dir', self.mock_env
+        '/remotedir', self.mock_env
     ) as tmp_directory:
       self.assertEqual(tmp_local_directory, tmp_directory)
       self.mock_env.execute_adb_call.assert_has_calls([
           mock.call(
               adb_pb2.AdbRequest(
                   pull=adb_pb2.AdbRequest.Pull(
-                      path=os.path.join('/remote/dir/', file_name)
+                      path=os.path.join('/remotedir/', file_name)
                   ),
                   timeout_sec=None,
               )