Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articulation #209

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Articulation #209

wants to merge 33 commits into from

Conversation

matansel
Copy link
Collaborator

add dynamic NeRF challenge

Copy link
Collaborator

@Qwlouse Qwlouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks pretty cool, thank you so much for putting this together, and apologies for taking so long to review. I've added a few minor comments. Once they are addressed I'd be happy to merge this.

@@ -270,11 +270,11 @@ def write_normal_batch(data, directory, file_template="normal_{:05d}.png", max_w
multi_write_image(data, path_template, write_fn=write_png, max_write_threads=max_write_threads)


def write_coordinates_batch(data, directory, file_template="object_coordinates_{:05d}.png",
def write_coordinates_batch(data, directory, file_template="object_coordinates_{:05d}.tiff",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not change from png to tiff here. That is a breaking change.
If you need coordinates as a tiff file, then add a new write_coordinates_batch_tif method and in your worker set kb.file_io.DEFAULT_WRITERS["object_coordinates"] = write_coordinates_batch_tif

missing_textures = sorted({img.filepath for img in bpy.data.images
if tuple(img.size) == (0, 0) or len(img.filepath)>1})
if missing_textures and not ignore_missing_textures:
raise RuntimeError(f"Missing textures: {missing_textures}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for inlining _check_missing_textures here?

@@ -6,6 +6,7 @@ etils[epath_no_tf]
cloudml-hypertune
google-cloud-storage
imageio
imageio-ffmpeg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be a mandatory kubric dependency just because the dynamic nerf worker uses it. I'd prefer adding specific instructions for additional dependencies to that worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants