Add dimissKeyboard to Swift interface #747
Conversation
| @@ -138,6 +138,14 @@ open class EarlGrey: NSObject { | |||
| .rotateDevice(to: orientation, | |||
| errorOrNil: errorOrNil) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
looks great. do you mind adding a test that uses this as well?
There was a problem hiding this comment.
Is there any test suite that tests the swift implementations? I've just found the Objective-C ones 😅
There was a problem hiding this comment.
Ah, sorry you're right. How about here: https://github.com/google/EarlGrey/blob/master/Demo/EarlGreyExample/EarlGreyExampleSwiftTests/EarlGreyExampleSwiftTests.swift ?
There was a problem hiding this comment.
Can't promise nothing until the weekend, but I'll try to make it work 😄
There was a problem hiding this comment.
Also, why does the build fail? 🤔
There was a problem hiding this comment.
Those look like legitimate test failures unrelated to your change.
@tirodkar mind taking a look?
|
This cl is good to go. Seems like there's a synch issue in the analytics test. The pinch flakes are know, though rare to catch. |
|
Can we merge this then? |
Adds a missing implementation in Swift for
dismissKeyboard.