Skip to content

Commit

Permalink
Fix show_buffering attribute values.
Browse files Browse the repository at this point in the history
The corresponding IntDef has changed without updating the attribute values.

Issue:#5139
PiperOrigin-RevId: 222598044
  • Loading branch information
tonihei authored and ojw28 committed Nov 23, 2018
1 parent f8a3c13 commit 1a9705e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
* Include channel count in audio capabilities check
([#4690](https://github.com/google/ExoPlayer/issues/4690)).
* Do not retry failed loads whose error is `FileNotFoundException`.
* Fix issue with applying the `show_buffering` attribute in `PlayerView`
([#5139](https://github.com/google/ExoPlayer/issues/5139)).

### 2.9.1 ###

Expand Down
4 changes: 2 additions & 2 deletions library/ui/src/main/res/values/attrs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
<attr name="auto_show" format="boolean"/>
<attr name="show_buffering" format="enum">
<enum name="never" value="0"/>
<enum name="always" value="1"/>
<enum name="when_playing" value="2"/>
<enum name="when_playing" value="1"/>
<enum name="always" value="2"/>
</attr>
<attr name="keep_content_on_player_reset" format="boolean"/>
<attr name="resize_mode"/>
Expand Down

0 comments on commit 1a9705e

Please sign in to comment.