Skip to content

Commit

Permalink
Move IMA SDK callbacks into inner class
Browse files Browse the repository at this point in the history
The release() method was added in the recent IMA API changes for
preloading and now 'collides' with the ExoPlayer AdsLoader release
method. This led to all ads completing being treated as a call to
completely release the ads loader, which meant that the ad playback
state was not updated on resuming after all ads had completed, which
in turn led to playback getting stuck buffering on returning from the
background after all ads played.

Move the IMA callbacks into an inner class to avoid this.

Issue: #7508
PiperOrigin-RevId: 316834561
  • Loading branch information
andrewlewis committed Jun 17, 2020
1 parent f85098a commit 28695d9
Show file tree
Hide file tree
Showing 3 changed files with 373 additions and 327 deletions.
3 changes: 3 additions & 0 deletions RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@
* Add option to skip ads before the start position.
* Catch unexpected errors in `stopAd` to avoid a crash
([#7492](https://github.com/google/ExoPlayer/issues/7492)).
* Fix a bug that caused playback to be stuck buffering on resuming from
the background after all ads had played to the end
([#7508](https://github.com/google/ExoPlayer/issues/7508)).
* Demo app: Retain previous position in list of samples.
* Add Guava dependency.

Expand Down
Loading

0 comments on commit 28695d9

Please sign in to comment.