Skip to content

Commit

Permalink
Improve housekeeping of ConcatenatingMediaSource callbacks.
Browse files Browse the repository at this point in the history
When calling releaseSource(), all pending messages will be removed. That means
that all action-on-completion callbacks which are somewhere in flight are
just dropped without being called. This change adds code to keep track of the
current state of each callback to allow all of them being called when the
source is released.

Issue:#5464
PiperOrigin-RevId: 232312528
  • Loading branch information
tonihei authored and ojw28 committed Feb 4, 2019
1 parent 9dc5c87 commit 6330d46
Show file tree
Hide file tree
Showing 3 changed files with 192 additions and 116 deletions.
2 changes: 2 additions & 0 deletions RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* OkHttp extension: Upgrade OkHttp dependency to 3.12.1.
* MP3: Wider fix for issue where streams would play twice on some Samsung
devices ([#4519](https://github.com/google/ExoPlayer/issues/4519)).
* Fix issue with dropped messages when releasing a `ConcatenatingMediaSource`
([#5464](https://github.com/google/ExoPlayer/issues/5464)).

### 2.9.4 ###

Expand Down
Loading

0 comments on commit 6330d46

Please sign in to comment.