-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codec regression when updating from 2.9.5 to 2.18.1 #10604
Comments
I updated the description. |
@lmartin You noted in your bug that the issue is reproducible with the demo app. Can you direct us to the content you used to reproduce this issue? |
Sorry but I can't share this private content. I fixed the issue by re-encoding the video with ffmpeg, I used this command : |
Added new method to check if codec just functionally supports a format. Changed getDecoderInfosSortedByFormatSupport to use new function to order by functional support. This allows decoders that only support functionally and are more preferred by the MediaCodecSelector to keep their preferred position in the sorted list. UnitTests included -Two MediaCodecVideoRenderer tests that verify hw vs sw does not have an effect on sort of the decoder list, it is only based on functional support Issue: #10604 PiperOrigin-RevId: 487779284
Added new method to check if codec just functionally supports a format. Changed getDecoderInfosSortedByFormatSupport to use new function to order by functional support. This allows decoders that only support functionally and are more preferred by the MediaCodecSelector to keep their preferred position in the sorted list. UnitTests included -Two MediaCodecVideoRenderer tests that verify hw vs sw does not have an effect on sort of the decoder list, it is only based on functional support Issue: google/ExoPlayer#10604 PiperOrigin-RevId: 487779284
ExoPlayer Version
2.18.1
Devices that reproduce the issue
Motorola Moto E (2nd gen) 4G LTE - Android 6.0 API 23
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps
Play mp4 video 1920x960@30fps
Expected result
Playback is smooth, hardware decoder is selected, log trace:
I MediaCodec: name=OMX.qcom.video.decoder.avc isType=false encoder=false
Actual result
Playback is jerky, fallback on software decoder, log trace:
D MediaCodecInfo: NoSupport [codec.profileLevel, avc1.4D0029, video/avc] [OMX.qcom.video.decoder.avc, video/avc] [surnia_umts, MotoE2(4G-LTE), motorola, 23]
I MediaCodec: name=OMX.google.h264.decoder isType=false encoder=false
Media
The same video but with a different codec profile works as expected (see attachment for logs).
Working video codec : avc1.640028
Not working video codec : avc1.4D0029
Bug Report
adb bugreport
to dev.exoplayer@gmail.com after filing this issue.exoplayerDemo-2.18.1-hw_failed.txt
exoplayerDemo-2.18.1-hw_success.txt
The text was updated successfully, but these errors were encountered: