-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vp8+vorbis file can not be played #1090
Comments
there are serval error log come:
below is the whole output log:
|
The root cause is the first of the errors:
It appears that this device has a VP8 decoder (
Once this block is added, you'll see one of (a) successful playback - in which case we'll apply a fix along these lines but targeted only at affected devices, (b) playback of audio only - in which case there's no alternate VP8 decoder and we'll have to do something else, (c) a different failure - in which case please provide details. Thanks. |
Thanks @ojw28 very much, By the way, I find the memory allocate is not enough,so I try to replace the sampleholder's memory manage mode, replace the code sadly, I don't get the right play either. So, @ojw28 ,what can we do to fixed this bug? |
Unfortunately it's not possible to replace the buffers when using platform provided decoders, because the platform is responsible (and requires ownership of) the allocations. The next thing you can try is explicitly setting a
where XXX is some sufficiently large value (it will need to be at least |
@ojw28 Well, thinking deeper, how to decide the proper maxInputSize value for VP_8 in this issue? And more, for other similar bugs on other special decoder in special device? Can we get a method to calculate the maxInputSize dynamically, not a const predefine value? |
Having to specify the size up front is an unfortunate limitation of the Android platform decoders, and is why this problem exists in the first place. @andrewlewis What do you think about having |
@ojw28 Well, a propel way need to be found for working around the issue. |
The max input size can be set to match the default input buffer size of the software VP8 decoder, which should be safe. |
just a heads up, we have had to update the input size in the software decoder when issues came up with high resolutions like 2k and 4k. it might change again in the future. nevertheless, here's where it is computed right now: http://androidxref.com/6.0.0_r1/xref/frameworks/av/media/libstagefright/codecs/on2/dec/SoftVPX.cpp#51 |
@ojw28 @andrewlewis It seems the default input size can be calculated as: A optimization method: Is that right? |
Issue: #1090 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=111607802
vp8+vorbis.mkv.zip
I have a test stream which contains vp8 video and vorbis audio.
when playing with exoplayer, I find it can not play successfully with video and audio tracks all on.
playwhenready=true,playbackstate=idle
But, if I turn off the video track, audio can be playback good.
Is it a bug of exoplayer to dealing with VP8 video codec?
notes: my device is HUAWEI G750-T01 android 4.2.2(API 17)
Can anybody give some idea to my problem? Thanks for replay
The text was updated successfully, but these errors were encountered: