-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExoPlayer IMA extension for SSAI DASH Live stream. #10912
Comments
The comment in the code snippet of Support of live streams with DASH (multi-period) is on the roadmap for Q1/2023. I'll keep this issue open and will report when we made some contributions for this. |
Hello! |
Sorry, no ETA besides that this is currently in the works. |
This change enables the IMA extension to play live DASH streams with DAI support. Samples streams can be found and played in the main demo app. Issue: google/ExoPlayer#10912 #minor-release PiperOrigin-RevId: 532407708
This change enables the IMA extension to play live DASH streams with DAI support. Samples streams can be found and played in the main demo app. Issue: #10912 #minor-release PiperOrigin-RevId: 532407708
This change enables the IMA extension to play live DASH streams with DAI support. Samples streams can be found and played in the main demo app. Issue: google/ExoPlayer#10912 #minor-release PiperOrigin-RevId: 532407708 (cherry picked from commit dab1353)
Is there a chance that this feature will be available in the next official release and what is the ETA for that release? |
Yes. The commit above is from the branch that will be merged into the release branch as 1.1.0-beta01. This is a process that already started. |
Are you commiting this change only to media3 branch or also to exoplayer "2.18.8" branch. We need this change pretty badly and we need to have this ASAP so would like to know if we should start migration from exoplayer to media3 (which we're planning to do anyway but would prefer to wait a little bit longer). Thanks @marcbaechinger |
Media3 1.1.0 beta01 is scheduled to be released on 7th June and will include the commit Marc linked above. ExoPlayer 2.19.0 will also include this commit and is scheduled to be released on 5th July (at the same time as Media3 1.1.0 stable) - so you can get the commit in a maven artifact about a month quicker by migrating to Media3. We're not planning an ExoPlayer 2.18.8 at the moment (that would correspond to Media3 1.0.3 which we're also not planning). If you need it earlier, you can depend on ExoPlayer locally: https://github.com/google/ExoPlayer#locally Please note that even with the commit above, seeking in DAI DASH live streams is not supported. |
Is seeking, in DAI DASH live streams not supported, an ExoPlayer extension limitation or is it Google Ad Manager DAI limitation and what is the path forward to resolving this? Thanks |
There are some edge-cases that can crash the player when seeking. That's why we declare it unsupported. The crashes I've seen happen under these conditions (this equally applies to HLS streams by the way):
A similar scenario can happen if the users seeks backwards into an ad group several times. Instead joining a live stream in 2), the seek creates the partial ad groups. This creates the same problem if metadata before the seek position is not available. The proper fix is to merge these ad groups at point 3 above, which is not really straight-forward. There is a possible easy fix that would simply ignore marking the second partial ad group, but in the context of apps expecting all played ads to be correctly reported this doesn't seem to be a good approach. If you have a stream that only has ad groups with a single ad, the above scenario can not happen. In this case seeking works as far as I have tested with the test streams available to me. At the moment I can't say when we get a chance to solve this. We are giving our best to get this into a roadmap as we agree this is an important feature. Sorry for not being able to give you a better answer. |
Thanks @marcbaechinger and @icbaker . This is very helpful! |
According to https://developers.google.com/interactive-media-ads/docs/sdks/android/dai/exoplayer-extension I should be able to do this:
but with CONTENT_TYPE_DASH instead of CONTENT_TYPE_HLS
When we try the setup as above we get IllegalStateException and upon further investigation we can trace the source of this exception to ImaServerSideAdInsertionUriBuilder.createStreamRequest(...) call.
We're using ExoPlayer version 2.18.2 and wondering when will you support DASH format for Live when using IMA SSAI?
The text was updated successfully, but these errors were encountered: