Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add drm key requests after player has been created #1924

Closed
SteUK opened this issue Oct 10, 2016 · 2 comments
Closed

Ability to add drm key requests after player has been created #1924

SteUK opened this issue Oct 10, 2016 · 2 comments

Comments

@SteUK
Copy link

SteUK commented Oct 10, 2016

Hi,

This is a feature request...sorry if I have missed an option somewhere or posting this in the wrong place!

Using ExoPlayer branch dev-2.0.0-rc

I using Axinom as a DRM solution service. This requires setting a drm key request - I am sure most of you know the procedure as it has been covered on here before.

What I would like to do is create my player up front, then later specify license tokens (created on demand). Currently have altered HttpMediaDrmCallback, adding two functions:

public void RemoveKeyRequestProperty( String key )
public void AddKeyRequestProperty( String key, String value )

...and removing the final from the variable keyRequestProperties.

Not sure if this is the best approach, but it seems to work for me.

Thanks!
Ste

@ojw28
Copy link
Contributor

ojw28 commented Oct 10, 2016

You'd still need to ensure you call your additional methods before any call to ExoPlayer.prepare, else you'd have no guarantee that the properties are set prior to requests being triggered. Are you doing this?

@SteUK
Copy link
Author

SteUK commented Oct 10, 2016

I sure am :) Playback is working as would be expected in our model.

Just wondered if the ability to do this is something that would be considered as an addition. Otherwise the player would need creating once a license token has been obtained (webservice), and a new player would be needed to be instantiated for every different video.

ojw28 added a commit that referenced this issue Feb 15, 2017
Issue: #1924

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=146120465
@ojw28 ojw28 closed this as completed Mar 16, 2017
@google google locked and limited conversation to collaborators Jul 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants