Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeekBar id exo_progress accessibility #2278

Closed
b77x opened this issue Jan 1, 2017 · 1 comment
Closed

SeekBar id exo_progress accessibility #2278

b77x opened this issue Jan 1, 2017 · 1 comment
Labels
bug

Comments

@b77x
Copy link

b77x commented Jan 1, 2017

On the demo app's exo_progress, android focusable is set to false. This makes it unable to be controlled without touch screen.

I created my own UI with facusable set true. When using touchscreen, the progress moves, however when using the keyboard arrows, the seekbar moves, but it gets updated again to the same position.
@ojw28
Copy link
Contributor

ojw28 commented Jan 2, 2017

It's deliberately not focusable. This is because the FF/RW buttons above it are focusable and can be used to seek more easily. TV devices often have controllers with physical FF/RW buttons, and these can also be used.

That said, we should definitely make sure it works correctly if it is made focusable, which isn't currently the case. We may also consider making it focusable by default if this makes seeking in long duration content easier (I'm not sure whether it does or not).

@ojw28 ojw28 added the bug label Jan 2, 2017
ojw28 added a commit that referenced this issue Jan 4, 2017
@ojw28
Make SeekBar work properly with key events if focusable
361241f 
This isn't perfect because it performs seeks whilst the
user is holding down L/R, rather than when they release
it. Performing the seek on release properly looks non
trivial, and would likely require extending SeekBar.

Issue: #2278

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=143440580
@ojw28 ojw28 closed this as completed Jan 4, 2017
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ojw28 @b77x