-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not stop playback when SimpleExoPlayerView.setPlayer(null) #2461
Comments
Please, see #2432. Thank you for the thorough report! |
Thanks suggestion! I fixed this issue. I write below commit for fix this issue. |
@AquilesCanta After investigating my implement above, I realized stream is stop little bit like buffering when I watching logcat during above situation, I want to prevent "buffering" ( stop streaming little bit ), are you know any solution, or impossible? |
Thanks for developing very useful library.
A description of the issue.
Not catching STATE_ENDED and not stop and keep moving position (player.getCurrentPosition()'s value) when position is exceeded to MediaSource's duration at specific condition.
(Sorry I'm just trying HlsMediaSource so I don't know other MediaSource)
I doubt that my project has two SimpleExoPlayerView and switch active view ( on the one hand is view#setPlayer(player) , on the other hand is view.setPlayer(null) ).
But I reproduced issue when single SimpleExoPlayerView and
setPlayer(null)
aftersetPlayer(player)
and prepare/play HLS source.Steps describing how the issue can be reproduced, ideally in the ExoPlayer demo app.
This issue is not reproduce ExoPlayer demo app.
(demo app doesn't provide
setPlayer(null)
)I make sample app that able to set player instance and null.
https://github.com/keima/ExoPlayerExample/tree/link/exoplayer-issue-overrun-position
How to reproduce:
[1] Prepare
button[2] setPlayer(player
and show controller in SimpleExoPlayerView[3] setPlayer(null)
before reach to 30min (about 1800000 milliseconds on debug text).The version of ExoPlayer being used.
r2.2.0 (I occured r2.0.2, but reproduced at latest version).
The text was updated successfully, but these errors were encountered: