You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We noticed a slight issue in Cea708 decoding , probably a typo/copy paste issue.
In Cea708Decoder.java :
private void handleC2Command(int command) {
// C2 Table doesn't contain any commands in CEA-708-B, but we do need to skip bytes
if (command <= **0x0F**) {
// Do nothing.
} else if (command <= 0x0F) {
serviceBlockPacket.skipBits(8);
} else if (command <= 0x17) {
serviceBlockPacket.skipBits(16);
} else if (command <= 0x1F) {
serviceBlockPacket.skipBits(24);
}
}
First check/skip should be with 0x07 instead of 0x0F.
As it is described in C2 Table contains no commands as of CEA-708 revision A:
if a command is seen in these code sets a decoder must skip an appropriate number of the following bytes.
0x00-0x07 +0 bytes
0x08-0x0f +1 byte
0x10-0x17 +2 bytes
0x18-0x1f +3 bytes
Could you have a look and do the appropriate update ?
Regards
The text was updated successfully, but these errors were encountered:
Hello,
We noticed a slight issue in Cea708 decoding , probably a typo/copy paste issue.
In Cea708Decoder.java :
First check/skip should be with 0x07 instead of 0x0F.
As it is described in C2 Table contains no commands as of CEA-708 revision A:
if a command is seen in these code sets a decoder must skip an appropriate number of the following bytes.
0x00-0x07 +0 bytes
0x08-0x0f +1 byte
0x10-0x17 +2 bytes
0x18-0x1f +3 bytes
Could you have a look and do the appropriate update ?
Regards
The text was updated successfully, but these errors were encountered: