First onVideoSizeChanged callback returns width=-1, height=-1 (Format.NO_VALUE) on Android 4.2 devices with Qualcomm 800 SoC #3007
Comments
|
Sounds like a bug with the decoder (presumably the OMX.qcom.video.decoder.avc implementation for this SoC). Perhaps the decoder outputs some video buffers before the format, which probably isn't a valid thing to do. We'll get hold of a device and try and reproduce. It should be pretty easy to provide a workaround (e.g. by just not reporting the size if it hasn't been set yet) if necessary. |
|
Yes, I'm doing just that, ignoring any video size updates until it actually makes sense. Thanks for looking into this! |
1. maybeRenotifyVideoSizeChanged should report reported* variables 2. Add check into maybeNotifyVideoSizeChanged to suppress reporting in the case that the width and height are still unknown. Issue: #3007 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=160879625
|
I merged a fix into |
|
Tested it on an LG G2 (Android 4.2.2, Qualcomm Snapdragon 800), no more negative values reported. Fixed, thanks. |
1. maybeRenotifyVideoSizeChanged should report reported* variables 2. Add check into maybeNotifyVideoSizeChanged to suppress reporting in the case that the width and height are still unknown. Issue: #3007 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=160879625
Issue description
First onVideoSizeChanged callback returns width=-1, height=-1 and pixelWidthHeightRatio=-1.0 (Format.NO_VALUE) on Android 4.2 devices with Qualcomm 800 SoC.
The correct Video Size is reported some time (around a few 100 ms) after.
I know this is not a major problem, but still, I'd like to know if this is an intentional behaviour or indeed a bug, as previous ExoPlayer versions (e.g: r1.5.10) did not produce this.
Reproduction steps
Open any HLS, DASH or other videos in the Demo App on a device with Qualcomm 800, running Android 4.2.
I used an LG G2 to verify the issue, but have multiple reports from other devices with the above config.
Link to test content
Any video in the ExoPlayer Demo App.
For example https://tungsten.aaplimg.com/VOD/bipbop_adv_example_v2/master.m3u8
Version of ExoPlayer being used
Confirmed on:
The issue was not present on r1.5.10.
Device(s) and version(s) of Android being used
Android 4.2, 4.2.2
Qualcomm 800 SoC
LG G2, LG G Flex, LG L22, Sony Z1, and others.
A full bug report captured from the device
If a full bug report is needed please let me know.
The relevant events follow:
The text was updated successfully, but these errors were encountered: