Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the Dolby Atmos support in 2.6.1 #4165

Closed
unext-wendong opened this issue Apr 23, 2018 · 2 comments
Closed

Question about the Dolby Atmos support in 2.6.1 #4165

unext-wendong opened this issue Apr 23, 2018 · 2 comments
Assignees
Labels

Comments

@unext-wendong
Copy link

This is one question about the change to support Dolby Atmos in release 2.6.1.
c3b92f8

One of changed places is in file MediaCodecUtil.java when querying for the decoders available for the mime type, audio/eac3-joc is tried first then audio/eac3.

From the change itself and the comment there, it seems to be for decoders which are able to decode Dolby Atmos streams but do not list audio/eac3-joc as their supported mime type (in their configuration file e.g. media_codecs.xml).

I think we are seeing one of those decoders. It works fine with version 2.6.0, but errors out on version 2.6.1 during codec configuration i.e. MediaCodec.configure(MediaFormat format, Surface surface, MediaCrypto crypto, int flags). It throws the IllegalArgumentException exception.

The reason seems to be that the passed in MediaFormat format in this method call contains audio/eac3-joc as the mime type instead of audio/eac3 even though this decoder was queried by using audio/eac3.

Wanted to confirm if it is a miss in this change that it should be using the same mime type to configure the decoder as the one used to query it.

@andrewlewis andrewlewis self-assigned this Apr 23, 2018
@andrewlewis
Copy link
Collaborator

This sounds like a bug. Please could you confirm that changing the MIME type of the format used to configure the codec to audio/eac3 fixes this? Thanks.

@unext-wendong
Copy link
Author

Please could you confirm that changing the MIME type of the format used to configure the codec to audio/eac3 fixes this? Thanks.

Yes, with this change the issue is not reproduced.

ojw28 pushed a commit that referenced this issue May 7, 2018
This may differ from the format MIME type for audio/eac3-joc.

Issue: #4165

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=193906521
@google google locked and limited conversation to collaborators Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants