You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is one question about the change to support Dolby Atmos in release 2.6.1. c3b92f8
One of changed places is in file MediaCodecUtil.java when querying for the decoders available for the mime type, audio/eac3-joc is tried first then audio/eac3.
From the change itself and the comment there, it seems to be for decoders which are able to decode Dolby Atmos streams but do not list audio/eac3-joc as their supported mime type (in their configuration file e.g. media_codecs.xml).
I think we are seeing one of those decoders. It works fine with version 2.6.0, but errors out on version 2.6.1 during codec configuration i.e. MediaCodec.configure(MediaFormat format, Surface surface, MediaCrypto crypto, int flags). It throws the IllegalArgumentException exception.
The reason seems to be that the passed in MediaFormat format in this method call contains audio/eac3-joc as the mime type instead of audio/eac3 even though this decoder was queried by using audio/eac3.
Wanted to confirm if it is a miss in this change that it should be using the same mime type to configure the decoder as the one used to query it.
The text was updated successfully, but these errors were encountered:
This sounds like a bug. Please could you confirm that changing the MIME type of the format used to configure the codec to audio/eac3 fixes this? Thanks.
This may differ from the format MIME type for audio/eac3-joc.
Issue: #4165
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=193906521
This is one question about the change to support Dolby Atmos in release 2.6.1.
c3b92f8
One of changed places is in file
MediaCodecUtil.java
when querying for the decoders available for the mime type,audio/eac3-joc
is tried first thenaudio/eac3
.From the change itself and the comment there, it seems to be for decoders which are able to decode Dolby Atmos streams but do not list
audio/eac3-joc
as their supported mime type (in their configuration file e.g.media_codecs.xml
).I think we are seeing one of those decoders. It works fine with version 2.6.0, but errors out on version 2.6.1 during codec configuration i.e.
MediaCodec.configure(MediaFormat format, Surface surface, MediaCrypto crypto, int flags)
. It throws theIllegalArgumentException
exception.The reason seems to be that the passed in
MediaFormat format
in this method call containsaudio/eac3-joc
as the mime type instead ofaudio/eac3
even though this decoder was queried by usingaudio/eac3
.Wanted to confirm if it is a miss in this change that it should be using the same mime type to configure the decoder as the one used to query it.
The text was updated successfully, but these errors were encountered: