Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline structure is only available after some delay. #5155

Closed
tonihei opened this issue Nov 27, 2018 · 1 comment
Closed

Timeline structure is only available after some delay. #5155

tonihei opened this issue Nov 27, 2018 · 1 comment
Assignees
@tonihei
Labels
enhancement low priority

Comments

@tonihei
Copy link
Collaborator

tonihei commented Nov 27, 2018

The timeline is still Timeline.EMPTY while the MediaSource is preparing for the first time and also doesn't reflect playlist changes with ConcatenatingMediaSource immediately. This is problematic for various reasons:

  1. It's against the usual ExoPlayer pattern of reflecting all changes immediately.
  2. It requires listeners and UI components to handle special cases for Timeline.EMPTY and a short period where the playlist of ConcatenatingMediaSource doesn't match the timeline.
  3. It prevents querying the first window index in a playlist (with shuffle mode enabled) before the first timeline is published. (See here).
  4. It prevents using the tag and player.getCurrentTag for UI handling in the mentioned cases. (See here and here).

Marking as low priority for now as it requires changes to the way we create and publish Timelines.
@tonihei tonihei self-assigned this Nov 27, 2018
This was referenced Nov 27, 2018
Closed
Closed
andrewlewis pushed a commit that referenced this issue Dec 10, 2018
@tonihei @andrewlewis
Use media source tag in dummy timeline.
c48b77d 
This is now possible as it's directly accessible from the media source.

Issue:#5177
Issue:#5155
PiperOrigin-RevId: 224321917
ojw28 pushed a commit that referenced this issue Dec 19, 2018
@tonihei @ojw28
Use media source tag in dummy timeline.
0e139e9 
This is now possible as it's directly accessible from the media source.

Issue:#5177
Issue:#5155
PiperOrigin-RevId: 224321917
@tonihei tonihei mentioned this issue Mar 4, 2019
Closed
@tonihei
Copy link
Collaborator Author

tonihei commented Sep 19, 2019

No longer an issue since playlist handling is part of the player API.

@tonihei tonihei closed this as completed Sep 19, 2019
@google google locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tonihei tonihei

Labels
enhancement low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tonihei